[PATCH] D44623: Fix asan on i?86-linux (32-bit) against glibc 2.27 and later

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a reviewer: vitalybuka.
kcc added a comment.

Is this related to https://github.com/google/sanitizers/issues/914 or this is another problem? 
(also: https://sourceware.org/ml/libc-alpha/2018-02/msg00567.html)

>> even when it should not

Any chance to get https://sourceware.org/glibc/wiki/ThreadPropertiesAPI moving?

Is a test possible? Or is this covered by an existing test? Which one?

I'm OOO for a few days, Vitaly, please review further.



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cc:190
+  void *get_tls_static_info_ptr = dlsym(RTLD_NEXT, "_dl_get_tls_static_info");
+#if defined(__i386__) && !__GLIBC_PREREQ(2, 27)
+  /* On i?86, _dl_get_tls_static_info used to be internal_function, i.e.
----------------
nested ifdefs? I'd prefer to avoid them. Move this code into a separate function, maybe? 


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cc:191
+#if defined(__i386__) && !__GLIBC_PREREQ(2, 27)
+  /* On i?86, _dl_get_tls_static_info used to be internal_function, i.e.
+     __attribute__((regparm(3), stdcall)) before glibc 2.27 and is normal
----------------
This code uses // comments. 


Repository:
  rL LLVM

https://reviews.llvm.org/D44623