[PATCH] D44625: Accept any filepath in llvm_check_source_file_list

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 19 13:36:11 PDT 2018


serge-sans-paille added inline comments.


================
Comment at: cmake/modules/LLVMProcessSources.cmake:84-89
     get_filename_component(fn ${g} NAME)
     if(ARG_SOURCE_DIR)
       set(entry "${g}")
     else()
       set(entry "${fn}")
     endif()
----------------
smeenai wrote:
> You should be able to delete this entire block now.
${entry} is still used in ``list(FIND LLVM_OPTIONAL_SOURCES ${entry} idx)``. I don't quite get where LLVM_OPTIONAL_SOURCES is set though.


https://reviews.llvm.org/D44625





More information about the llvm-commits mailing list