[PATCH] D44549: allow-multiple-definitions should completely suppress errors instead of making them warnings.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola accepted this revision.
espindola added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:515
     replaceSymbol<Defined>(S, &F, Name, Binding, StOther, Type, 0, 0, nullptr);
-  else if (Cmp == 0)
+  else if (Cmp == 0 && !Config->AllowMultipleDefinition)
     reportDuplicate(S, &F);
----------------
ruiu wrote:
> espindola wrote:
> > Please leave the check for AllowMultipleDefinition in reportDuplicate. Both overloads should check it or none.
> > 
> Done.
Have you forgot to upload a new patch? In any case, LGTM with that.


https://reviews.llvm.org/D44549