[PATCH] D44509: Remove unnecessary includes from lld/ELF

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

When I'm writing code for lld, I'm trying to maintain the include file list so that a .cpp file includes everything that the file uses, as indirect file inclusion feels somewhat fragile and not explicit. Because I'm doing that by hand, I'm pretty sure that we miss a lot of header files, but the spirit is to make the include list more explicit than implicit (and making things explicit and obvious is probably more "lld-ish", I would say). So I'm included to not do this.

Maybe you now have a question as to why we don't enforce it by a tool then? I think if everybody agrees that we should use a tool and always include what you use, that's fine, but I personally don't have enough motivation to propose that. In addition to that, it is in practice hard to ask everyone (including one-time contributors) to use some tool. So status quo is ok to me. Thank you for your patch anyways!


Repository:
  rL LLVM

https://reviews.llvm.org/D44509