[PATCH] D43781: Make AddrSpaceCast noops on PPC

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 19 08:17:29 PDT 2018


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: test/CodeGen/PowerPC/addrspacecast.ll:1
+; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu %s -o /dev/null
+
----------------
I'm not sure how `/dev/null` works for targets I'm not familiar with (like Windows). Is this a common thing to do?
It might not be a terrible thing to actually do `< %s | FileCheck %s` and then maybe just a `CHECK-LABEL` to verify we've actually generated assembly.

But in either case, I assume that `lit` checks for the return code from the `llc` invocation, so I'm fine either way.


Repository:
  rL LLVM

https://reviews.llvm.org/D43781





More information about the llvm-commits mailing list