[PATCH] D43781: Make AddrSpaceCast noops on PPC

Valentin Churavy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 19 07:49:04 PDT 2018


vchuravy updated this revision to Diff 138926.
vchuravy added a comment.

fix typos


Repository:
  rL LLVM

https://reviews.llvm.org/D43781

Files:
  lib/Target/PowerPC/PPCISelLowering.h
  test/CodeGen/PowerPC/addrspacecast.ll


Index: test/CodeGen/PowerPC/addrspacecast.ll
===================================================================
--- /dev/null
+++ test/CodeGen/PowerPC/addrspacecast.ll
@@ -0,0 +1,20 @@
+; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu %s -o /dev/null
+
+; Check that codegen for an addrspace cast succeeds without error.
+define <4 x i32 addrspace(1)*> @f (<4 x i32*> %x) {
+  %1 = addrspacecast <4 x i32*> %x to <4 x i32 addrspace(1)*>
+  ret <4 x i32 addrspace(1)*> %1
+}
+
+; Check that fairly complicated addrspace cast and operations succeed without error.
+%struct = type opaque
+define void @g (%struct addrspace(10)** %x) {
+  %1 = load %struct addrspace(10)*, %struct addrspace(10)** %x
+  %2 = addrspacecast %struct addrspace(10)* %1 to %struct addrspace(11)*
+  %3 = bitcast %struct addrspace(11)* %2 to i8 addrspace(11)*
+  %4 = getelementptr i8, i8 addrspace(11)* %3, i64 16
+  %5 = bitcast i8 addrspace(11)* %4 to %struct addrspace(10)* addrspace(11)*
+  %6 = load %struct addrspace(10)*, %struct addrspace(10)* addrspace(11)* %5
+  store %struct addrspace(10)* %6, %struct addrspace(10)** undef
+  ret void
+}
Index: lib/Target/PowerPC/PPCISelLowering.h
===================================================================
--- lib/Target/PowerPC/PPCISelLowering.h
+++ lib/Target/PowerPC/PPCISelLowering.h
@@ -884,6 +884,11 @@
       }
     };
 
+    bool isNoopAddrSpaceCast(unsigned SrcAS, unsigned DestAS) const override {
+      // Addrspacecasts are always noops.
+      return true;
+    }
+
     bool canReuseLoadAddress(SDValue Op, EVT MemVT, ReuseLoadInfo &RLI,
                              SelectionDAG &DAG,
                              ISD::LoadExtType ET = ISD::NON_EXTLOAD) const;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43781.138926.patch
Type: text/x-patch
Size: 1712 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180319/b889bdba/attachment.bin>


More information about the llvm-commits mailing list