[PATCH] D27296: Don't assume mingw is providing SSP functions

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Isn't this only an issue if you actually enable it (via `-fstack-protector-strong` to clang, or something similar in parameters to llvm codegen)?

This change in itself is right though, since we shouldn't be using those MSVC specific if targeting mingw.

But if I try building code with clang with this patch in place with `-fstack-protector-strong`, I get an assertion failure ("Assertion failed: (InChain.getValueType() == MVT::Other && "Not a chain"), function HandleMergeInputChains, file ../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp, line 2557.") while I previously got a successful compile (but referencing the MSVC specific symbols). So I'm not sure exactly what and how this patch fixes.

So IMO the patch looks something in the right direction, but it doesn't seem to be complete to me. It at least needs a test case and showing what it fixes, and the assertion failure I quoted needs to be sorted out in one way or another.


Repository:
  rL LLVM

https://reviews.llvm.org/D27296