[PATCH] D42728: Add more warnings for implict conversions (e.g. double truncation to float).

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 16 03:53:36 PDT 2018


avt77 added a comment.

In https://reviews.llvm.org/D42728#1038501, @lebedev.ri wrote:

> In https://reviews.llvm.org/D42728#1038500, @avt77 wrote:
>
> > I fixed all issues raised by ABataev and committed the patch as revision 327618. I'll close the review in some hours.
>
>
> You are aware that you can either use `arc patch` (best way), or at least manually add `Differential revision: https://reviews.llvm.org/Dsomething` line to the commit msg, so
>
> 1. the differential is auto-closed
> 2. the commit msg is taken from differential description
> 3. there is a trivial way to go from commit to differential (and vice versa) ?


If I'm sure in success I'm using "Differential revision" but sometimes I'd prefer to wait until the patch is really accepted by the system and only after that I'm closing it by hand.
But what's about `arc patch`? Could you point me to any docs about?


https://reviews.llvm.org/D42728





More information about the llvm-commits mailing list