[PATCH] D44519: Add llvm-exegesis tool.

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

In https://reviews.llvm.org/D44519#1039849, @courbet wrote:

> In https://reviews.llvm.org/D44519#1039845, @kristof.beyls wrote:
>
> > Thanks for sharing this - this looks like a really promising tool.
> >  I wonder if you have thought about adding unit/regression tests? Having them would make it quite a bit easier for others to contribute to its development.
>
>
> Sure, we do have unit tests (they are gmock unit tests, not lit tests). I did not include them in this diff to make review more manageable, but I'll add them now if you want.


I had expected something based on gmock unit tests to be needed here.
I think it could help the review as the unit tests might give further guidance to how the tool works by documenting examples of inputs and expected outputs?
I probably won't be the one to be able to review all of this - but at least I would find it helpful to see the unit tests as part of trying to review at least part of this.
So, yes, please do add them :)


Repository:
  rL LLVM

https://reviews.llvm.org/D44519