[compiler-rt] r327700 - tsan: revert: Update buildgo.sh to pass -isysroot on Darwin.

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 16 03:20:59 PDT 2018


Author: dvyukov
Date: Fri Mar 16 03:20:58 2018
New Revision: 327700

URL: http://llvm.org/viewvc/llvm-project?rev=327700&view=rev
Log:
tsan: revert: Update buildgo.sh to pass -isysroot on Darwin.

This commit breaks actual Go runtime build on gomote builders (10.12) with:

xcode-select: error: tool 'xcodebuild' requires Xcode,
but active developer directory '/Library/Developer/CommandLineTools'
is a command line tools instance

Without this part build works fine.
The original commit does not include any explanation as to why
it is needed.


Modified:
    compiler-rt/trunk/lib/tsan/go/buildgo.sh

Modified: compiler-rt/trunk/lib/tsan/go/buildgo.sh
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/go/buildgo.sh?rev=327700&r1=327699&r2=327700&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/go/buildgo.sh (original)
+++ compiler-rt/trunk/lib/tsan/go/buildgo.sh Fri Mar 16 03:20:58 2018
@@ -85,7 +85,7 @@ elif [ "`uname -a | grep NetBSD`" != ""
 	"
 elif [ "`uname -a | grep Darwin`" != "" ]; then
 	SUFFIX="darwin_amd64"
-	OSCFLAGS="-fPIC -Wno-unused-const-variable -Wno-unknown-warning-option -isysroot $(xcodebuild -version -sdk macosx Path) -mmacosx-version-min=10.7"
+	OSCFLAGS="-fPIC -Wno-unused-const-variable -Wno-unknown-warning-option -mmacosx-version-min=10.7"
 	OSLDFLAGS="-lpthread -fPIC -fpie -mmacosx-version-min=10.7"
 	SRCS="
 		$SRCS




More information about the llvm-commits mailing list