[PATCH] D44550: [InstCombine] canonicalize fcmp+select to fabs

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 15 18:20:55 PDT 2018


spatel created this revision.
spatel added reviewers: mike.dvoretsky, efriedma, craig.topper.
Herald added a subscriber: mcrosier.

This is based on the DAG patterns as shown in https://reviews.llvm.org/D44091. I'm hoping that we can just remove those DAG folds and always rely on IR canonicalization to handle the matching to fabs.

We would still need to delete the broken code from DAGCombiner to fix PR36600:
https://bugs.llvm.org/show_bug.cgi?id=36600


https://reviews.llvm.org/D44550

Files:
  lib/Transforms/InstCombine/InstCombineSelect.cpp
  test/Transforms/InstCombine/fabs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44550.138657.patch
Type: text/x-patch
Size: 9345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180316/1ba732e9/attachment.bin>


More information about the llvm-commits mailing list