[PATCH] D44291: [ARM, AArch64] Check the no-stack-arg-probe attribute for dynamic stack probes

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:7530
 
+  if (DAG.getMachineFunction().getFunction().hasFnAttribute(
+          "no-stack-arg-probe")) {
----------------
aemerson wrote:
> This is unfortunate, ideally we could fall back to Expand here.
Yes, I'd like to do that - do you have any suggestions on how to?


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:7537
+    SDValue Ops[2] = {SP, Chain};
+    return DAG.getMergeValues(Ops, dl);
+  }
----------------
aemerson wrote:
> What about the alignment?
Right, will fix.


https://reviews.llvm.org/D44291