[PATCH] D44448: Add DebugLoc information to WebAssembly block and loop.

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 15 10:34:02 PDT 2018


dschuff added a comment.

Otherwise LGTM



================
Comment at: test/CodeGen/WebAssembly/dbg-loop-loc.ll:1
+; RUN: llc < %s -O0 -verify-machineinstrs | FileCheck %s
+
----------------
This test probably belongs in `test/DebugInfo/WebAssembly`


================
Comment at: test/CodeGen/WebAssembly/dbg-loop-loc.ll:4
+; Test verifies if .loc is properly set for loop and block instructions --
+; the line number is not a 0 when DebugLoc is defined.
+
----------------
Can you also include a comment with the source of dbg-loop-loc.c to make it easy to regenerate this file?


Repository:
  rL LLVM

https://reviews.llvm.org/D44448





More information about the llvm-commits mailing list