[PATCH] D44425: [InstSimplify] peek through unsigned FP casts for sign-bit compares (PR36682)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 15 04:09:49 PDT 2018


lebedev.ri updated this revision to Diff 138525.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.

> simplifyICmpWithConstant()? I think you'd have to put it above the m_APInt() check in that function in order to still get some of the vector tests with undef elements though.

Yep, thanks, looks less out-of-place there!

The `GetCompareTy(RHS)` change will be a preparatory NFC commit before the main commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D44425

Files:
  lib/Analysis/InstructionSimplify.cpp
  test/Transforms/InstSimplify/cast-unsigned-icmp-cmp-0.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44425.138525.patch
Type: text/x-patch
Size: 10223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180315/35954c41/attachment.bin>


More information about the llvm-commits mailing list