[PATCH] D44388: [ELF] Rework debug line parsing to use llvm::Error (LLD-side)

Thu Mar 15 04:04:14 PDT 2018

jhenderson updated this revision to Diff 138522.
jhenderson added a comment.

Fixed use of auto and variable name. Also fixed a bug which I'd accidentally introduced - my changes to getOrParseLineTable meant that it reported an error, if an invalid offset was specified. This meant that an object with an empty or missing .debug_line section would result in a warning printed from this function whenever LLD tried to look up the debug information for reporting its own message. I've added a couple of tests to check this going forwards.

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44388

Files:
  ELF/InputFiles.cpp
  test/ELF/Inputs/undef-bad-debug.s
  test/ELF/no-line-parser-errors-if-empty-section.s
  test/ELF/no-line-parser-errors-if-no-section.s
  test/ELF/undef.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44388.138522.patch
Type: text/x-patch
Size: 4948 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180315/4933b6e5/attachment.bin>