[PATCH] D44419: [SCEV][NFC] Remove TBB, FBB parameters from exit limit computations

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:6946
+    bool ExitByCond = !L->contains(BI->getSuccessor(0));
+    assert(ExitByCond == L->contains(BI->getSuccessor(1)) &&
+           "It should have one successor in loop and one exit block!");
----------------
fhahn wrote:
>  I think in some cases, it could be triggered with this change whereas no assertion was triggered before, e.g. ExitByCond being something not understood by computeExitLimitFromCondImpl. But I think it makes sense to only use it for branches with one successor in the loop and one outside.
This is what an exiting block is by definition.


https://reviews.llvm.org/D44419