[PATCH] D43996: [llvm-objcopy] Implement support for .group sections.

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 15:08:44 PDT 2018


alexshap updated this revision to Diff 138461.
alexshap added a comment.

1. Add tests for groups (switch to llvm-readobj -elf-section-groups and add yaml-based tests for both cases (where the content of the group changes and where it doesn't)
2. Add support for .sh_info (and update the tests accordingly) + address the inline comments.
3. This diff doesn't include the larger refactoring of the hierarchy of sections (partially discussed in the comments)

(this reorganization is relatively large and kind of unrelated to the main goal of this patch, i would prefer to move that discussion to a separate future patch). However this patch still contains some minor fixes ("explicit", "private etc") which I've made for consistency with my code, however if it's a blocker I'm fine to split them out into a separate small diff.


Repository:
  rL LLVM

https://reviews.llvm.org/D43996

Files:
  test/tools/llvm-objcopy/Inputs/groups.o
  test/tools/llvm-objcopy/group-unchanged.test
  test/tools/llvm-objcopy/group.test
  test/tools/llvm-objcopy/strip-dwo-groups.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43996.138461.patch
Type: text/x-patch
Size: 21499 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180314/c683ffd4/attachment.bin>


More information about the llvm-commits mailing list