[PATCH] D44349: [WebAssembly] Verify contents of relocations target before writing it

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I doubt that you really need to do that for every invocation of the linker. Generally speaking, relocation handling is what you want to optimize the most because the number of relocation can be really huge (it can be tens of millions). In addition to that, there are a lot of different ways that a compiler can be wrong, and catching only one error in the linker doesn't make much sense to me. Why is finding this particular error so important? We generally trust compilers that they create sane object files. To be honest, I think we should remove this check completely.


Repository:
  rL LLVM

https://reviews.llvm.org/D44349