[PATCH] D44422: [ELF] - Never create .gnu_hash with NBuckets == 0.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 11:47:57 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1805
+  // section to indicate to a loader that the file exports no symbols. We can't
+  // have zero buckets because the android loader doesn't support that. We chose
+  // load factor 4 for the on-disk hash table. For each hash collision, the
----------------
Please separate sentences with blank lines. The sentence about an Android loader workaround and "We chose ..." are talking about completely different stuff, so this is confusing.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44422





More information about the llvm-commits mailing list