[PATCH] D44275: Add the ability to stamp a PDB / EXE with a given GUID / Age, and use it to test LLD reproducibility

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 11:30:18 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

Sorry for the delay



================
Comment at: llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp:1174
+
+      support::ulittle32_t *Ptr = reinterpret_cast<support::ulittle32_t*>(PdbBufferPtr->getBufferStart() + *Off);
+      *Ptr = opts::stamp::Age;
----------------
Needs wrapping, here and elsewhere. I'm assuming clang-format will happen at some point.


https://reviews.llvm.org/D44275





More information about the llvm-commits mailing list