[PATCH] D44453: Update Error Message

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:818
+        " in readonly segment; lld by default doesn't allow text relocations. \
+        Recompile object files with -fPIC to not create such relocations or \
+        pass '-z notext' to allow text relocations for lld" +
----------------
arichardson wrote:
> I would not use line continuations here.
Yes. I think your actual error message contains a lot of spaces between "relocations." and "Recompile object files..." because of the indentation of the next line. In general line continuation should be avoided. You can just write two string literals  without any operator or anything to make compiler concatenate the two strings.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44453