[PATCH] D44401: [AMDGPU] Always use IDX for load/store format intrinsics.

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 14 03:45:01 PDT 2018


nhaehnle added a comment.

We need tests for the store case as well.

I think it's fine to keep the existing intrinsics, but this causes a subtle change (or clarification) of semantics. Could you please add a comment in IntrinsicsAMDGPU.td explaining that buffer.{load,store}.format.* expects a buffer with stride != 0, while the non-format intrinsics expect a buffer with stride == 0?


Repository:
  rL LLVM

https://reviews.llvm.org/D44401





More information about the llvm-commits mailing list