[PATCH] D44414: Error instead of producing broken binary

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Arch/X86.cpp:68
+  //   compiled without -fPIE/-fPIC and doesn't maintain ebx.
+  // * If a libray definition gets preempted to the executable, it will have the
+  //   wrong ebx value.
----------------
a libra**r**y


================
Comment at: ELF/Arch/X86.cpp:70
+  //   wrong ebx value.
+  if (Config->Pic)
+    SupportsPltPreemption = false;
----------------
Comment saying "for PIE", but `Config->Pic` also covers DSO, we have `Config->Pie` for PIE. Is this `if` correct?
We will report "cannot be used against symbol" for -shared case, so I think it can be `if (Config->Pie)`.


https://reviews.llvm.org/D44414