[PATCH] D44001: [SCEV] Prove implications for SCEVUnknown Phis

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:9585
+        continue;
+      assert(dominates(LHS, IncBB) && "Dominance broken?");
+      const SCEV *R = getSCEV(RPhi->getIncomingValueForBlock(IncBB));
----------------
This may fail if LHS is also a Phi from the same BB, but not a SCEVUnknown. It seems that it should be a check instead of assert.


https://reviews.llvm.org/D44001