[PATCH] D44313: [WebAssembly] Implement GC for imports

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/Symbols.cpp:68
+  // Assume any other kind of symbol is live (we don't track liveness for
+  // undefined data, or for synthetic data symbols with no InputSegment).
   return true;
----------------
I think this was nicer how you had it before.  Why not just use a single bit on the symbol base class?  Especially since we are about to add undefined data to the final output.. we don't want to repeat the ImportLive again.

I also don't have a problem with the Live bit of a symbol mirroring the Live bit on the segment it points too, I think both concepts are useful.

For this kind of switch case, I think we are moving towards just using dyn_cast<>.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44313