[PATCH] D44344: [WebAssembly] Avoid COMDAT hashmap lookup for each symbol. NFC

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 11:44:46 PDT 2018


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: wasm/InputChunks.h:165
   StringRef getName() const override { return Name; }
-  StringRef getComdat() const override { return StringRef(); }
+  uint32_t getComdat() const override { return UINT32_MAX; }
 
----------------
I feel like it would be good to have some kind of `wasm::kInvalidIndex` that we could use here and elsewhere.   But thats a separate change.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44344





More information about the llvm-commits mailing list