[PATCH] D44235: [LTO/gold] Support --wrap

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 10:44:40 PDT 2018


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: tools/gold/gold-plugin.cpp:581
+    }
+    for (; count > 0; --count) {
+      StringRef Name = wrap_symbols[count - 1];
----------------
Seems a little odd to have this loop go in reverse. Unless there is some reason to do that, I'd write it in the conventional way.


Repository:
  rL LLVM

https://reviews.llvm.org/D44235





More information about the llvm-commits mailing list