[PATCH] D35430: DA: remove uses of GEP, only ask SCEV

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 10:03:50 PDT 2018


sebpop added a comment.

> Requiring assertions for the tests is not too bad, although I think it would be better to use optimization remarks, which should be available in release mode too.

whenever it was possible to use -pass-remarks=loop-interchange I used that.
The loop interchange pass needs to output more diagnostic about why it failed to interchange when using -pass-remarks.
Then the tests can be moved back to not require asserts.

> But we definitely need at least some tests that check the actual IR, to make sure the actual transformation is performed (or not performed) and correct.

What about adding new correctness tests for loop interchange to the test-suite?


Repository:
  rL LLVM

https://reviews.llvm.org/D35430





More information about the llvm-commits mailing list