[PATCH] D44391: Export LLVM_DYLIB_COMPONENTS in LLVMConfig.cmake

Evangelos Foutras via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 09:44:24 PDT 2018


foutrelis added a comment.

You have a point that any further tweaks to `llvm_config` should be created and reviewed separately. What I described above is not too great either; it shouldn't be required to specify `USE_SHARED`.

Ideally `llvm_config(foo <list-of-components>)` would work similar to `llvm-config --libs <list-of-components`. The latter defaults to using the dylib if LLVM is built with `LLVM_LINK_LLVM_DYLIB=ON`.

I'm not sure I can come up with a proper patch for this. With three build modes and in/out-of-tree builds, it gets confusing quite fast. 😕

In order to not derail this much further, I'll proceed to follow bug 35245 <https://bugs.llvm.org/show_bug.cgi?id=35245> and post there if I manage to cobble something together.


Repository:
  rL LLVM

https://reviews.llvm.org/D44391





More information about the llvm-commits mailing list