[llvm] r327408 - [ThinLTO] Clear dllimport when setting dso_local.

[Rafael Espindola via llvm-commits]

Author: rafael
Date: Tue Mar 13 08:24:51 2018
New Revision: 327408

URL: http://llvm.org/viewvc/llvm-project?rev=327408&view=rev
Log:
[ThinLTO] Clear dllimport when setting dso_local.

This is PR36686.

If a user of a library is LTOed with that library we take the
opportunity to set dso_local, but we don't clear dllimport, which
creates an invalid IR.

Added:
    llvm/trunk/test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll
    llvm/trunk/test/ThinLTO/X86/dsolocal_dllimport.ll
Modified:
    llvm/trunk/lib/Transforms/Utils/FunctionImportUtils.cpp

Modified: llvm/trunk/lib/Transforms/Utils/FunctionImportUtils.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/FunctionImportUtils.cpp?rev=327408&r1=327407&r2=327408&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/FunctionImportUtils.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/FunctionImportUtils.cpp Tue Mar 13 08:24:51 2018
@@ -206,8 +206,11 @@ void FunctionImportGlobalProcessing::pro
   // definition.
   if (GV.hasName()) {
     ValueInfo VI = ImportIndex.getValueInfo(GV.getGUID());
-    if (VI && VI.isDSOLocal())
+    if (VI && VI.isDSOLocal()) {
       GV.setDSOLocal(true);
+      if (GV.hasDLLImportStorageClass())
+        GV.setDLLStorageClass(GlobalValue::DefaultStorageClass);
+    }
   }
 
   bool DoPromote = false;

Added: llvm/trunk/test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll?rev=327408&view=auto
==============================================================================
--- llvm/trunk/test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll (added)
+++ llvm/trunk/test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll Tue Mar 13 08:24:51 2018
@@ -0,0 +1,5 @@
+target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-windows-msvc19.11.0"
+define dso_local dllexport i32 @foo() {
+  ret i32 42
+}

Added: llvm/trunk/test/ThinLTO/X86/dsolocal_dllimport.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ThinLTO/X86/dsolocal_dllimport.ll?rev=327408&view=auto
==============================================================================
--- llvm/trunk/test/ThinLTO/X86/dsolocal_dllimport.ll (added)
+++ llvm/trunk/test/ThinLTO/X86/dsolocal_dllimport.ll Tue Mar 13 08:24:51 2018
@@ -0,0 +1,16 @@
+; RUN: opt -module-summary %s -o %t1.bc
+; RUN: opt -module-summary %S/Inputs/dsolocal_dllimport.ll -o %t2.bc
+; RUN: llvm-lto2 run %t1.bc %t2.bc -o %t -r=%t1.bc,bar,px -r=%t1.bc,__imp_foo, -r=%t2.bc,foo -save-temps
+; RUN: llvm-dis < %t.1.3.import.bc | FileCheck %s
+
+; If a user (dllimport) is LTOed with a library, check that we replace dllimport with dso_local.
+
+; CHECK: declare dso_local void @foo()
+
+target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-windows-msvc19.11.0"
+define void @bar() {
+  call void @foo()
+  ret void
+}
+declare dllimport void @foo()