[PATCH] D44176: [mips] Add support for CRC ASE

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with inline nits addressed.



================
Comment at: lib/Target/Mips/Disassembler/MipsDisassembler.cpp:1136
 }
+// Auto-generated decoder wouldn't add the third operand for CRC32*.
+template <typename InsnType>
----------------
Newline before and after what you've added here.


================
Comment at: lib/Target/Mips/Mips64r6InstrInfo.td:119
 }
+class CRC32D_DESC  : CRC_DESC_BASE<"crc32d", GPR32Opnd, II_CRC32D>;
+class CRC32CD_DESC : CRC_DESC_BASE<"crc32cd", GPR32Opnd, II_CRC32CD>;
----------------
Nit: New line before and after this hunk.


================
Comment at: test/MC/Disassembler/Mips/crc/valid-64r6-el.txt:1
+# RUN: llvm-mc --disassemble %s -triple=mipsel-unknown-linux -mcpu=mips64r6 \
+# RUN:   -mattr=+crc | FileCheck %s
----------------
Triple here should be mips64el-unknown-linux-gnu.


================
Comment at: test/MC/Disassembler/Mips/crc/valid-64r6.txt:1
+# RUN: llvm-mc --disassemble %s -triple=mips-unknown-linux -mcpu=mips64r6 \
+# RUN:   -mattr=+crc | FileCheck %s
----------------
Triple here should be mips64-unknown-linux-gnu.


================
Comment at: test/MC/Mips/crc/invalid64.s:3
+#
+# RUN: not llvm-mc %s -triple=mips-unknown-linux -mcpu=mips64r6 \
+# RUN:     -mattr=+crc 2>%t1
----------------
Triple here should be mips64-unknown-linux-gnu.


================
Comment at: test/MC/Mips/crc/module-crc.s:1
+# RUN: llvm-mc %s -triple=mips64-unknown-linux -mcpu=mips32r6 | \
+# RUN:   FileCheck %s -check-prefix=CHECK-ASM
----------------
Triple here should be mips-unknown-linux-gnu.


================
Comment at: test/MC/Mips/crc/module-crc.s:4
+#
+# RUN: llvm-mc %s -triple=mips64-unknown-linux -mcpu=mips32r6 \
+# RUN:   -filetype=obj -o - | \
----------------
Triple here should be mips-unknown-linux-gnu.


================
Comment at: test/MC/Mips/crc/set-nocrc-directive.s:4
+# RUN: FileCheck %s < %t1
+# RUN: not llvm-mc %s -triple=mips-unknown-unknown -show-encoding \
+# RUN:     -mcpu=mips64r6 -mattr=+crc 2>%t1
----------------
Triple here should be mips64-unknown-linux-gnu.


================
Comment at: test/MC/Mips/crc/valid.s:3
+# RUN:   -mattr=+crc | FileCheck %s
+# RUN: llvm-mc %s -triple=mips-unknown-linux -show-encoding -mcpu=mips64r6 \
+# RUN:   -mattr=+crc | FileCheck %s
----------------
Triple here should be mips64-unknown-linux-gnu.


================
Comment at: test/MC/Mips/crc/valid64.s:1
+# RUN: llvm-mc %s -triple=mips-unknown-linux -show-encoding -mcpu=mips64r6 \
+# RUN:   -mattr=+crc | FileCheck %s
----------------
Triple here should be mips64-unknown-linux-gnu.


Repository:
  rL LLVM

https://reviews.llvm.org/D44176