[llvm] r327359 - [LTO] Return proper error object rather than null LTOModule

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 12 21:37:01 PDT 2018


Author: anemet
Date: Mon Mar 12 21:37:01 2018
New Revision: 327359

URL: http://llvm.org/viewvc/llvm-project?rev=327359&view=rev
Log:
[LTO] Return proper error object rather than null LTOModule

This caused a crash in LTOModule::createInLocalContext.

rdar://37926841

Modified:
    llvm/trunk/lib/LTO/LTOModule.cpp

Modified: llvm/trunk/lib/LTO/LTOModule.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LTOModule.cpp?rev=327359&r1=327358&r2=327359&view=diff
==============================================================================
--- llvm/trunk/lib/LTO/LTOModule.cpp (original)
+++ llvm/trunk/lib/LTO/LTOModule.cpp Mon Mar 12 21:37:01 2018
@@ -208,7 +208,7 @@ LTOModule::makeLTOModule(MemoryBufferRef
   std::string errMsg;
   const Target *march = TargetRegistry::lookupTarget(TripleStr, errMsg);
   if (!march)
-    return std::unique_ptr<LTOModule>(nullptr);
+    return make_error_code(object::object_error::arch_not_found);
 
   // construct LTOModule, hand over ownership of module and target
   SubtargetFeatures Features;




More information about the llvm-commits mailing list