[PATCH] D44384: [DEBUGINFO] Add -no-dwarf-debug-ranges option.

[David Blaikie via llvm-commits]

On Mon, Mar 12, 2018 at 12:52 PM Alexey Bataev via Phabricator <
reviews at reviews.llvm.org> wrote:

> ABataev added inline comments.
>
>
> ================
> Comment at: test/DebugInfo/X86/no_debug_ranges.ll:4
> +
> +; DISABLED-NOT:  {{DW_AT_ranges|.debug_ranges}}
> +; DISABLED:      .section .debug_info
> ----------------
> dblaikie wrote:
> > probably check for only .debug_ranges here? (since it's outside the
> debug_info section, so any mention of DW_AT_ranges wouldn't be too relevant
> (short of the abbrev section, but no need to check for that when you're
> checking for the contents of debug_info anyway, I think))
> There can be .debug_abbrev section with DW_AT_ranges, we need to be sure
> that no ranges info is generated
>

Right, but the same property is already tested for in the debug_info
section testing, I think.


>
>
> ================
> Comment at: test/DebugInfo/X86/no_debug_ranges.ll:6
> +; DISABLED:      .section .debug_info
> +; DISABLED-NOT:  {{DW_AT_ranges|.debug_ranges}}
> +; DISABLED:      .quad .Lfunc_begin0 # DW_AT_low_pc
> ----------------
> dblaikie wrote:
> > probably replace ".debug_ranges" with ".section" here? (ie: make sure
> the low/high pc you're checking for is in the debug_info section, and make
> sure that section doesn't include a DW_AT_ranges)
> Ok
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D44384
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180312/b45af690/attachment.html>