[PATCH] D43795: [New PM][IRCE] port of Inductive Range Check Elimination pass to the new pass manager

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D43795#1035180, @fedor.sergeev wrote:

> In https://reviews.llvm.org/D43795#1035151, @chandlerc wrote:
>
> > I would just suggest making BPI required as part of the loop standard analyses.
> >  It should be a separate patch (with clear discussion pointing out why it is useful), but BPI is useful to *many* loop passes I suspect, I just think we hadn't wired it up previously.
>
>
> Should this separate BPI patch go before or after this change?


I think before.

> 
> 
>> As part of this we should do some basic testing to make sure that the loop passes preserve BPI correctly.
> 
> Checking -debug-pass-manager output for "Running analysis:" and  absence of "Invalidating analysis:", right?

I think you'll also need to do some deeper testing ... possibly by verifying BPI between each loop pass?

We need to have a better mechanism for doing this than we currently have, especially for the loop standard passes


Repository:
  rL LLVM

https://reviews.llvm.org/D43795