[PATCH] D43795: [New PM][IRCE] port of Inductive Range Check Elimination pass to the new pass manager

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:45
 //===----------------------------------------------------------------------===//
-
+#include "llvm/Transforms/Scalar/InductiveRangeCheckElimination.h"
 #include "llvm/ADT/APInt.h"
----------------
asbirlea wrote:
> Alphabetical order of includes?
This is a "Main Module Header" according to llvm coding standard, so it should go first.
Unless I'm misreading.


================
Comment at: lib/Transforms/Scalar/LoopDistribute.cpp:998
       [&](Loop &L) -> const LoopAccessInfo & {
-    LoopStandardAnalysisResults AR = {AA, AC, DT, LI, SE, TLI, TTI, nullptr};
+    LoopStandardAnalysisResults AR = {AA,  AC,  DT,      LI,     SE,
+                                      TLI, TTI, nullptr, nullptr};
----------------
asbirlea wrote:
> clang-format (whole patch)
I believe this funny indentation of LI, SE above was created exactly by clang-format.
I would write it differently if it was just me ;)

And yes, I will rerun clang-format on a whole patch once more to see if I missed anything.


Repository:
  rL LLVM

https://reviews.llvm.org/D43795