[PATCH] D43507: [SCEV] Fix isKnownPredicate

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm (didn't review the logic based on @mkazantsev 's LGTM).



================
Comment at: include/llvm/Analysis/ScalarEvolution.h:848
+  /// related to L2 remains the same.
+  /// The primary goal of this function is an utility function for
+  /// isKnownPredicate.
----------------
Let's drop

```
  /// The primary goal of this function is an utility function for
  /// isKnownPredicate.
```

for now.  Statements like that don't clarify things very much, and has a tendency to get stale.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:8771
+
+// Domination relationship must be a linear order on collected loops.
+#ifndef NDEBUG
----------------
This comment should be indented.


https://reviews.llvm.org/D43507