[PATCH] D44160: [GVN] Detect fully redundant loads when we have more than one available value

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 12 09:08:01 PDT 2018


dberlin added a comment.

So this looks like a really weird optimization to avoid AA being broken.
As you say, the code it inserts will be fixed up later (and you are taking an O(1) function and making it O(N).
We should just fix AA.

It should see no difference between the two.
If we really can't fix AA, i'd like to understand why before we go this route.
Because we shouldnt' be working around these problems this way.


Repository:
  rL LLVM

https://reviews.llvm.org/D44160





More information about the llvm-commits mailing list