[PATCH] D34135: [JumpThreading] Use DT to avoid processing dead blocks

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 12 08:53:43 PDT 2018


dberlin accepted this revision.
dberlin added a comment.
This revision is now accepted and ready to land.

I'm a little worried about the duplicated code here. I feel like you are having to patch way too many  points in the same function, and it will be easy to miss one in the future if someone changes the logicc slightly.

Is there really no better place to put this/way to refactor it?

If not, i'll approve, but just wanted to check.


https://reviews.llvm.org/D34135





More information about the llvm-commits mailing list