[PATCH] D44367: [InstCombine] peek through FP casts for sign-bit compares (PR36682)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D44367#1034253, @lebedev.ri wrote:

> Ok, i have limited the test generator to just the `sitofp`, `slt 0` / `sle -1` / `sgt -1` / `sge 0`, added `undef` in the middle of vector variant.
>  Good news is that all the scalar cases are indeed handled.
>  Bad news is that half of the vector cases is not handled.


Ah, you're detecting a missing undef pattern match for m_Zero(). Nobody made that change to that matcher yet, unlike m_AllOnes().

> Unless it is because i'm using yesterday's trunk, I think the test coverage needs improving.
>  I think i should go ahead and commit that initial testfile now, unless it is too large?

I think that's fine. We can always remove some tests if we think they don't add value.


https://reviews.llvm.org/D44367