[PATCH] D44345: [X86] Add comments to the end of FMA3 instructions to make the operation clear

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 17:44:30 PST 2018


craig.topper created this revision.
craig.topper added reviewers: spatel, v_klochkov, RKSimon.

There are 3 different operand orders for FMA instructions so figuring out the exact operation being performed requires a lot of thought.

This patch adds a comment to the end of the assembly line to print the exact operation.

I think I've got all the instructions in here except the ones with builtin rounding.

I didn't update all tests, but I assume we can get them as we regenerate tests in the future.


https://reviews.llvm.org/D44345

Files:
  lib/Target/X86/InstPrinter/X86InstComments.cpp
  test/CodeGen/X86/avx512-intrinsics.ll
  test/CodeGen/X86/avx512vl-intrinsics.ll
  test/CodeGen/X86/fma-commute-x86.ll
  test/CodeGen/X86/fma-intrinsics-x86.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44345.137883.patch
Type: text/x-patch
Size: 137225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180310/38125e06/attachment-0001.bin>


More information about the llvm-commits mailing list