[PATCH] D44327: ObjCARC: teach the cloner about funclets

[David Majnemer via Phabricator via llvm-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:692
+                   DenseMap<BasicBlock *, ColorVector> &BlockColors) {
+  auto *CI = dyn_cast<CallInst>(&I);
+  assert(CI && "CloneCallInst must receive a CallInst");
----------------
dyn_cast -> cast

Actually, why not just take a CallInst &?


================
Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:698
+    auto Bundle = CI->getOperandBundleAt(I);
+    // funclets will be reassociated in the future
+    if (Bundle.getTagID() == LLVMContext::OB_funclet)
----------------
Start the comment with an uppercase and end with a period.


Repository:
  rL LLVM

https://reviews.llvm.org/D44327