[PATCH] D44316: [WebAssembly] Demangle symbol names for use by the browser debugger

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:531
+  auto Demangle = [](StringRef Name) {
+    if (Config->Demangle)
+      if (Optional<std::string> S = demangleItanium(Name))
----------------
I'm not sure the demanding config option should be used here.   Lets just pick one format the for the name section and stick with it (i.e. lets always demanding here).  

I had indented the demanding config option (which I notice is actually uninitialzed!, oops) to be for the linker output and error mesages to make them more readable. That seems orthogonal to the format the names sections which should be fixed one way to the other IMHO.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44316