[PATCH] D43172: [SelectionDAG][ARM][X86] Teach PromoteIntRes_SETCC to do a better job picking the result type for the setcc.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:593
+  // getSetCCResultType query. Otherwise, we might get back a type that
+  // still needs to be promoted.
+  if (getTypeAction(InVT) == TargetLowering::TypePromoteInteger)
----------------
Please explicitly note this is a heuristic.


================
Comment at: test/CodeGen/X86/bitcast-and-setcc-512.ll:49
 ; SSE-NEXT:    # kill: def $al killed $al killed $eax
 ; SSE-NEXT:    retq
 ;
----------------
I guess the problem here is specifically that the new version doesn't use packssdw?


Repository:
  rL LLVM

https://reviews.llvm.org/D43172