[PATCH] D44328: Support embedding natvis files in PDBs.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, but we should try to use .s tests when we can because they are smaller and easier to maintain.



================
Comment at: lld/test/COFF/Inputs/generic.yaml:1
+--- !COFF
+header:
----------------
I don't think we need a codeview object to test natvis. I think you can do something like the pdb-lib.s test instead and get rid of this generic.yaml input file.


https://reviews.llvm.org/D44328