[PATCH] D44028: [WebAssembly] Handle weak undefined functions with a synthetic stub

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: wasm/Symbols.h:315
 // Returns a symbol name for an error message.
-std::string toString(const wasm::Symbol &Sym);
+std::string toString(const wasm::Symbol &Sym, bool QuoteDemangled = true);
 std::string toString(wasm::Symbol::Kind Kind);
----------------
Please revert this change. toString() is supposed to be a stringize function for an object, so it should print out only the information of object itself, and no information should be included other than that. Passing a second argument for "supplemental" purpose break that principle.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44028