[PATCH] D44195: TableGen: Remove the cast-from-string-to-variable-reference feature

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 10:14:03 PST 2018


tra added a comment.

What happens now when someone attempts to cast a variable name?
Will the !cast remain unresolved or will we see a "symbol  X not found" error? Both would be somewhat confusing as that X may be something that is obviously there (e.g. template parameter). I'd rather see an explicit error telling me exactly what's wrong. Something like "!cast to a local symbol is not allowed".


Repository:
  rL LLVM

https://reviews.llvm.org/D44195





More information about the llvm-commits mailing list