[PATCH] D44286: [lld-link] Add support for /ignore:4037.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 03:35:29 PST 2018


thakis added inline comments.


================
Comment at: COFF/Driver.cpp:809
+      if (Config->WarnMissingOrderSymbol)
+        warn("/order:" + Arg + ": missing symbol: " + S);
+    }
----------------
hans wrote:
> Higher-level question: link.exe prints the warning number here, so the user can figure out what /ignore option to pass. Is there some way we can let an lld-link.exe user figure out how to ignore this warning?
This is imho an excellent question, and I wondered about this myself. /ignore:4217 (already implemented) has the same problem – so since this is consistent with that warning, I figured I don't need to figure this out right now.

lld-link's warning configurability is generally nonexistent, making this even less obvious. Maybe we should add "[/ignore:N to ignore]" to the end of the warning text for warnings that have a disable flag? That seems like a good approach to me – Rui, what do you think? But that should be a separate patch.


https://reviews.llvm.org/D44286





More information about the llvm-commits mailing list