[PATCH] D44280: [llvm-readobj] Extend the output of -elf-section-groups with the field Link

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 01:35:08 PST 2018


jhenderson added a comment.

I'm thinking that we should really either have both the sh_info and the sh_link fields printed, or neither. At the moment, they're kind of implicit in the "Signature" field, since that is the symbol name for the corresponding symbol. If the name is wrong, then we're pointing at either the wrong symbol table or the wrong entry in that table. I suppose there's not technically anything stopping there being multiple symbols with the same name though, under the right circumstances, so having both would allow us to uniquely identify it. However, printing only the link doesn't uniquely identify it.


Repository:
  rL LLVM

https://reviews.llvm.org/D44280





More information about the llvm-commits mailing list