[PATCH] D44291: [ARM, AArch64] Check the no-stack-arg-probe attribute for dynamic stack probes

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 01:14:13 PST 2018


mstorsjo created this revision.
mstorsjo added reviewers: hans, compnerd, aemerson, nruslan.
Herald added subscribers: kristof.beyls, javed.absar, rengolin.

This extends the use of this attribute on ARM and AArch64 from SVN r325900 where it was only checked for fixed stack allocations on ARM/AArch64, but for both fixed and dynamic stack allocations on X86).

This also adds a testcase for the existing use of disabling the fixed stack probe with the attribute on ARM and AArch64.

The manual SelectionDAG code for subtracting from the SP register feels very clunky; is there any way to make this fall back to the default behaviour of Expand in this particular case, instead of handcoding it?


Repository:
  rL LLVM

https://reviews.llvm.org/D44291

Files:
  lib/Target/AArch64/AArch64ISelLowering.cpp
  lib/Target/ARM/ARMISelLowering.cpp
  test/CodeGen/AArch64/no-stack-arg-probe.ll
  test/CodeGen/AArch64/win-alloca-no-stack-probe.ll
  test/CodeGen/ARM/Windows/alloca-no-stack-arg-probe.ll
  test/CodeGen/ARM/Windows/chkstk-no-stack-arg-probe.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44291.137702.patch
Type: text/x-patch
Size: 4440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180309/19e21043/attachment.bin>


More information about the llvm-commits mailing list