[PATCH] D43323: [NFC] Consolidate six getPointerOperand() utility functions into one place
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 9 01:13:47 PST 2018
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
I agree this is a nice cleanup, too.
Being a move to `Instructions.h` is a big deal.
But given that this commons up many independent components, and that this code truly belongs to that header file (and it's not such a big change), and that other maintainers and developers have acknowledge it, I'm going out on a limb and approving this patch.
We can always revert if it causes trouble, but I'm not expecting any.
cheers,
--renato
https://reviews.llvm.org/D43323
More information about the llvm-commits
mailing list